Move component data wrapper to frequenz.sdk.simulate - #245
Closed
mathias-baumann-frequenz wants to merge 1 commit into
Closed
Move component data wrapper to frequenz.sdk.simulate#245mathias-baumann-frequenz wants to merge 1 commit into
mathias-baumann-frequenz wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
part:tests
mathias-baumann-frequenz
force-pushed
the
make_data_wrapper_accessable
branch
3 times, most recently
from
March 9, 2023 15:41
3017e10 to
230f49b
Compare
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
mathias-baumann-frequenz
force-pushed
the
make_data_wrapper_accessable
branch
from
March 9, 2023 15:43
230f49b to
5ebc3d2
Compare
ela-kotulska-frequenz
approved these changes
Mar 9, 2023
leandro-lucarella-frequenz
requested changes
Mar 10, 2023
leandro-lucarella-frequenz
left a comment
leandro-lucarella-frequenz
left a comment
Contributor
There was a problem hiding this comment.
I really don't like the name, so just blocking this from being merged until we discuss it.
Contributor
Author
|
I am not using this after all now that we have the battery pool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it can be used in actors as well.